Added Reddcoin (RDD) support #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes to work with Reddcoin. To create a valid Reddcoin transaction the following changes were made to 'timestamp': - Moved from 'header' section into 'footer' ie. next to 'locktime' during serialization. - it's serialized into rawtransaction as 4-byte little endian field at the end. - it does *not* participate in the hash used for signing the transaction.
|
Closed, not selected |
|
Please advise why "Closed, not selected"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes necessary for adding Reddcoin support on the KeepKey hardware wallet.
Explanation of code changes:
timestamp(UNIX little-endian) field appended at the end during serialization. That field has been added to the relevant code parts and changes made to accommodate that.timestampfield support in protobufs definition.[SignTx]and[PrevTxMeta]message needs to include a non-zerouint32 timestampvalue from the host. Omitting this field(or0value) meanstimestampwon't be serialized as part of final rawtransaction. It's done this way to keep compatibility with other btc-style transactions like Bitcoin Cash, Dogecoin, Dash etc. since that field is always omitted.Note about reddcoin transaction. The
timestampdoes not participate in the prehash that's being signed but it does participate in the final txid hash. This means for a reddcoin transaction, thetimestampcould be modified without invalidating the signature but will change the txid.Also note most of the changes involving
timestampare just backported from https://github.com/keepkey/trezor-firmware/blob/f4e6a4ed2a4f0bb7cf82b4e143f16a73e7845779/legacy/firmware/signing.c but adapted to work with reddcoin.