refactor: Refactor alert and incident property handling. #3941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
No linked issues found. Please add the corresponding issues in the pull request description. |
Introduce cached properties for `alerts` and `incidents` to ensure data enrichment on first access. Refactor related code for better encapsulation and consistency, replacing direct attribute access with structured methods.
VladimirFilonov
force-pushed
the
refactor/encapsulate-_alerts-n-_incidents
branch
from
51e85f6 to
9daaf60
Compare
|
@VladimirFilonov closing this draft for now as it's hanging for a long time. let's re-open it when it's ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce cached properties for
alertsandincidentsto ensure data enrichment on first access. Refactor related code for better encapsulation and consistency, replacing direct attribute access with structured methods.Closes #
📑 Description
✅ Checks
ℹ Additional Information