Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): time represntation to locale time #3282

Conversation

talboren
Copy link
Member

@talboren talboren commented Feb 3, 2025

No description provided.

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 7:16am

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. UI User interface related issues labels Feb 3, 2025
Copy link
Contributor

@skynetigor skynetigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

skynetigor
skynetigor previously approved these changes Feb 3, 2025
…does-not-coincide-with-the-time-of-the-notification-from-checkmk
…does-not-coincide-with-the-time-of-the-notification-from-checkmk
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 3, 2025
@talboren talboren enabled auto-merge (squash) February 3, 2025 07:10
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.59%. Comparing base (5fec2ce) to head (a8d9830).
Report is 76 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3282      +/-   ##
==========================================
+ Coverage   42.60%   46.59%   +3.99%     
==========================================
  Files         182      152      -30     
  Lines       17835    14089    -3746     
==========================================
- Hits         7598     6565    -1033     
+ Misses      10237     7524    -2713     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talboren talboren merged commit 751dae0 into main Feb 3, 2025
14 checks passed
@talboren talboren deleted the 3248-bug-the-time-of-the-displayed-timeline-does-not-coincide-with-the-time-of-the-notification-from-checkmk branch February 3, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. UI User interface related issues
Projects
None yet
3 participants