fix: Add incident resolution logic for enriched alerts #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:M
Implemented logic to check and resolve incidents when all associated alerts are resolved. Updated the enrichment API to handle alert sessions and incident status changes. Enhanced test coverage to validate the new behavior.
Previously, resolution checks were triggered unconditionally. This change ensures that `should_check_incidents_resolution` is set to `True` only when the alert status is explicitly marked as "resolved," improving logic accuracy.
The import for `RulesEngine` in `alerts.py` was unused and has been removed to clean up the code. This helps maintain clarity and avoids unnecessary dependencies.
VladimirFilonov
force-pushed
the
fix/3142-bug-incident-is-not-closing-automatically
branch
from
7978d31 to
6cd5b0f
Compare
talboren
deleted the
fix/3142-bug-incident-is-not-closing-automatically
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented logic to check and resolve incidents when all associated alerts are resolved. Updated the enrichment API to handle alert sessions and incident status changes. Enhanced test coverage to validate the new behavior.
Closes #3142
📑 Description
✅ Checks
ℹ Additional Information