-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(providers): Wazuh Provider #3065
Conversation
@Motii1 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Looks great, awesome work! |
@traceroute42 can you also sign the CLA so we can further push that in? |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE!
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #3065 +/- ##
==========================================
+ Coverage 43.06% 43.07% +0.01%
==========================================
Files 166 167 +1
Lines 16685 16741 +56
==========================================
+ Hits 7186 7212 +26
- Misses 9499 9529 +30 β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some docker-compose.yml
that spins up Wazuh with the custom-keep.py
? so I can re-run it locally and check everything good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it, let's merge
@Motii1 reached out to me that he would love to test this one more. Thank you! |
|
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
15359980 | Triggered | Generic Private Key | db918c7 | keep/providers/clickhouse_provider/clickhouse-secure/certs/server.key | View secret |
π Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
π¦ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Matvey Kukuy <Matvey-Kuk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
π Fantastic work @traceroute42! Your very first PR to keep has been merged! ππ₯³ You've just taken your first step into open-source, and we couldn't be happier to have you onboard. π For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! π©βπ»π¨βπ» |
Signed-off-by: Matvey Kukuy <Matvey-Kuk@users.noreply.github.com> Co-authored-by: Dawid Motak <dawidmotak1@gmail.com> Co-authored-by: Tal Borenstein <tal@keephq.dev> Co-authored-by: Shahar Glazner <shaharglazner@gmail.com> Co-authored-by: Matvey Kukuy <motakuk@gmail.com> Co-authored-by: Matvey Kukuy <Matvey-Kuk@users.noreply.github.com>
Closes #2702
π Description
The PR is intended to be the first version of integration with Wazuh.
It integrates with usage of the Wazuh custom integrations feature
β Checks