Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): Wazuh Provider #3065

Merged
merged 16 commits into from
Feb 4, 2025
Merged

feat(providers): Wazuh Provider #3065

merged 16 commits into from
Feb 4, 2025

Conversation

traceroute42
Copy link
Contributor

@traceroute42 traceroute42 commented Jan 19, 2025

Closes #2702

πŸ“‘ Description

The PR is intended to be the first version of integration with Wazuh.
It integrates with usage of the Wazuh custom integrations feature

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Copy link

vercel bot commented Jan 19, 2025

@Motii1 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 19, 2025
@CLAassistant
Copy link

CLAassistant commented Jan 19, 2025

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added Documentation Improvements or additions to documentation Feature A new feature Provider Providers related issues labels Jan 19, 2025
@traceroute42 traceroute42 changed the title Add PoC of Wazuh Provider feat: Add PoC of Wazuh Provider Jan 19, 2025
@talboren
Copy link
Member

Looks great, awesome work!
@traceroute42 mind adding a screenshot of an alert that Keep received from Wazuh in the alerts feed? Cool stuff!

CleanShot 2025-01-20 at 09 24 18

@talboren
Copy link
Member

@traceroute42 can you also sign the CLA so we can further push that in?

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
keep βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 4, 2025 7:39am

talboren
talboren previously approved these changes Jan 20, 2025
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 43.07%. Comparing base (e8cbcb3) to head (4ddd276).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3065      +/-   ##
==========================================
+ Coverage   43.06%   43.07%   +0.01%     
==========================================
  Files         166      167       +1     
  Lines       16685    16741      +56     
==========================================
+ Hits         7186     7212      +26     
- Misses       9499     9529      +30     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some docker-compose.yml that spins up Wazuh with the custom-keep.py? so I can re-run it locally and check everything good?

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Jan 20, 2025
Matvey-Kuk
Matvey-Kuk previously approved these changes Jan 21, 2025
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it, let's merge

@Matvey-Kuk
Copy link
Contributor

@Motii1 reached out to me that he would love to test this one more. Thank you!

@Motii1
Copy link
Contributor

Motii1 commented Jan 29, 2025

Looks great, awesome work! @traceroute42 mind adding a screenshot of an alert that Keep received from Wazuh in the alerts feed? Cool stuff!

No problem. I have generated some simple events:
image
image

Copy link

gitguardian bot commented Jan 30, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

πŸ”Ž Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15359980 Triggered Generic Private Key db918c7 keep/providers/clickhouse_provider/clickhouse-secure/certs/server.key View secret
πŸ›  Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


πŸ¦‰ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@shahargl shahargl changed the title feat: Add PoC of Wazuh Provider feat(providers): Wazuh Provider Feb 4, 2025
shahargl
shahargl previously approved these changes Feb 4, 2025
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 4, 2025
Signed-off-by: Matvey Kukuy <Matvey-Kuk@users.noreply.github.com>
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Matvey-Kuk Matvey-Kuk merged commit d1324ba into keephq:main Feb 4, 2025
11 checks passed
Copy link
Contributor

github-actions bot commented Feb 4, 2025

πŸ† Fantastic work @traceroute42! Your very first PR to keep has been merged! πŸŽ‰πŸ₯³

You've just taken your first step into open-source, and we couldn't be happier to have you onboard. πŸ™Œ
If you're feeling adventurous, why not dive into another issue and keep contributing? The community would love to see more from you! πŸš€

For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

skynetigor pushed a commit that referenced this pull request Feb 5, 2025
Signed-off-by: Matvey Kukuy <Matvey-Kuk@users.noreply.github.com>
Co-authored-by: Dawid Motak <dawidmotak1@gmail.com>
Co-authored-by: Tal Borenstein <tal@keephq.dev>
Co-authored-by: Shahar Glazner <shaharglazner@gmail.com>
Co-authored-by: Matvey Kukuy <motakuk@gmail.com>
Co-authored-by: Matvey Kukuy <Matvey-Kuk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Feature A new feature lgtm This PR has been approved by a maintainer Provider Providers related issues size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[πŸ”Œ Provider]: Wazuh cyber related alerts can be very helpful
6 participants