Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sorting of advanced attribute list #10091

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Fix sorting of advanced attribute list #10091

merged 1 commit into from
Feb 1, 2025

Conversation

marco-langer
Copy link
Contributor

Sort advanced attribute list using locale aware sort.

Fixes #6175

Testing strategy

  1. Add an entry to a database
  2. Go to "Edit entry" -> "Advanced"
  3. Add some additional attributes via the "Add" button. E.g.: "Test1", "Test12", "Test2"
  4. The additional attributes should be sorted now as "Test1", "Test2", "Test12"

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@marco-langer marco-langer marked this pull request as draft December 10, 2023 18:53
@droidmonkey droidmonkey added this to the v2.8.0 milestone Jan 6, 2024
@droidmonkey droidmonkey modified the milestones: v2.8.0, v2.7.10 Aug 19, 2024
@droidmonkey droidmonkey marked this pull request as ready for review January 12, 2025 17:14
@marco-langer @droidmonkey
Fix sorting of advanced attribute list
c1dd402 
Sort advanced attribute list using locale aware sort.

Fixes keepassxreboot#6175
@droidmonkey droidmonkey force-pushed the fix/advanced-attribute-list-sort branch from 052993a to c1dd402 Compare January 22, 2025 04:44
@droidmonkey droidmonkey merged commit 8ca90a0 into keepassxreboot:develop Feb 1, 2025
9 checks passed
pull bot pushed a commit to Graysonbarton/keepassxc that referenced this pull request Feb 1, 2025
@marco-langer @pull
Fix sorting of advanced attribute list (keepassxreboot#10091)
4d5c37d 
Sort advanced attribute list using locale aware sort.

Fixes keepassxreboot#6175
droidmonkey pushed a commit that referenced this pull request Feb 2, 2025
@marco-langer @droidmonkey
Fix sorting of advanced attribute list (#10091)
1a11a55 
Sort advanced attribute list using locale aware sort.

Fixes #6175
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droidmonkey droidmonkey droidmonkey approved these changes

Assignees
No one assigned
Labels
pr: backported Pull request backported to previous release user interface
Projects
None yet
Milestone
v2.7.10
Development

Successfully merging this pull request may close these issues.

Sort advanced attribute list using locale aware sort
2 participants
@marco-langer @droidmonkey