Implemented CoinGecko api to get token prices #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sajalbnl
commented
Oct 5, 2024
•
sajalbnl
commented
- issue [feat] Implement CoinGecko api to get token prices #86
- follows contribution guide
- code change includes tests
- breaking change
# Conflicts: # wallet_app/android/app/src/main/AndroidManifest.xml # wallet_app/android/app/src/main/java/com/example/walletapp/MainActivity.kt # wallet_app/android/app/src/main/java/com/example/walletapp/WalletActivity.kt # wallet_app/android/app/src/main/java/com/example/walletapp/ui/activity/AccountBalanceActivity.kt
trbutler4
requested changes
Oct 6, 2024
| suspend fun getTokenPrices( | ||
| ids: String, | ||
| vsCurrencies: String | ||
| ): Response<Map<String, Map<String, Double>>> { |
There was a problem hiding this comment.
can you change this type to be a named type like TokenPriceResponse
| suspend fun getTokenPrices( | ||
| @Query("ids") ids: String, // Comma-separated token IDs | ||
| @Query("vs_currencies") vsCurrencies: String // Comma-separated currency codes | ||
| ): Response<Map<String, Map<String, Double>>> |
There was a problem hiding this comment.
reuse named TokenPriceResponse type here
|
resolved conflicts and merged locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.