Implement OP_WITHIN opcode #28
Conversation
| } | ||
|
|
||
| fn opcode_within(ref engine: Engine) { | ||
| let a = engine.dstack.pop_int(); |
There was a problem hiding this comment.
Would be prefered to make the variable naming here more explicit, like min_value, max_value, ...
There was a problem hiding this comment.
Will rename the variables now
There was a problem hiding this comment.
Hi I just pushed an update to rename the variables to be more explicit
src/opcodes/opcodes.cairo
Outdated
| }); | ||
| } | ||
|
|
||
| fn opcode_within(ref engine: Engine) { |
There was a problem hiding this comment.
Please refer to this implementation to see the proper ordering of variables on the stack : https://github.com/btcsuite/btcd/blob/b161cd6a199b4e35acec66afc5aad221f05fe1e3/txscript/opcode.go#L1844
There was a problem hiding this comment.
Working on this
There was a problem hiding this comment.
Hi, opcode_within is number 165 in the order, please could you tell me what you mean? I have pushed an update where I renamed and reordered the variables though
There was a problem hiding this comment.
So we have to make sure the values poped off the stack are in the same order as the bitcoin spec, so here max_value should be popped first, then min_value, then selected_value
There was a problem hiding this comment.
Hi @b-j-roberts I have rearranged the variables based on the order max before min before value
I implemented the code for op_within