Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support to deserialize transaction with witness data #259

Merged
merged 2 commits into from
Oct 16, 2024
Merged

feat: add support to deserialize transaction with witness data #259

merged 2 commits into from
Oct 16, 2024
+95 −8

Conversation

ptisserand
Copy link
Contributor

  • issue #
  • follows contribution guide
  • code change includes tests

This PR add support to deserialize transaction with witness data

@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024

@ptisserand is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

b-j-roberts
b-j-roberts approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this will help a lot with the witness based tests! Thank you!

@b-j-roberts b-j-roberts merged commit 5b9f8c9 into keep-starknet-strange:main Oct 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-roberts b-j-roberts b-j-roberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptisserand @b-j-roberts