refactor: use sha256 utils #256
Open
+8
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bloomingpeach is attempting to deploy a commit to the keep-starknet-strange Team on Vercel. A member of the Team first needs to authorize it. |
b-j-roberts
requested changes
Oct 16, 2024
| }; | ||
| engine.dstack.push_byte_array(res2_bytes); | ||
| let res = sha256_byte_array(@m); | ||
| let res2 = sha256_byte_array(@res); |
There was a problem hiding this comment.
Could you change this one to use double sha?
shinigami/packages/utils/src/hash.cairo
Line 13 in ce878fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I working on fixing the test, I came across this improvement. This PR uses
sha256_byte_arrayhelper where possible