Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Implement OP_2, OP_3, ..., OP_16 opcodes #5

Closed
b-j-roberts opened this issue Jul 24, 2024 · 4 comments
Closed

[feat] Implement OP_2, OP_3, ..., OP_16 opcodes #5

b-j-roberts opened this issue Jul 24, 2024 · 4 comments
Assignees
@ptisserand @hakymulla
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@b-j-roberts
Copy link
Contributor

Implement the OP_X opcodes using the opcode_n function like OP_1 from shinigami

References

opcode_n
Guide on how to add an opcode in shinigami
@b-j-roberts b-j-roberts added enhancement New feature or request good first issue Good for newcomers labels Jul 24, 2024
@hakymulla
Copy link
Contributor

can i take this?

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Jul 25, 2024

Hey @hakymulla!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@ptisserand
Copy link
Contributor

@b-j-roberts I need at least OP_2 to test implementation of OP_MIN #17
Is it ok if I add OP_{2..16} in the same PR ?

ptisserand added a commit to ptisserand/shinigami that referenced this issue Jul 25, 2024
@ptisserand
feat: keep-starknet-strange#5 add OP_[2..16] opcodes
7746fcd
@hakymulla hakymulla mentioned this issue Jul 25, 2024
Merged
3 tasks
ptisserand added a commit to ptisserand/shinigami that referenced this issue Jul 25, 2024
@ptisserand
feat: keep-starknet-strange#5 add OP_[2..16] opcodes
480a943
@ptisserand ptisserand mentioned this issue Jul 25, 2024
Merged
4 tasks
ptisserand added a commit to ptisserand/shinigami that referenced this issue Jul 26, 2024
@ptisserand
feat: keep-starknet-strange#5 add OP_[2..16] opcodes
00fa591
@b-j-roberts
Copy link
Contributor Author

Thank ya'll for the rapid turn around on this issue! @ptisserand @hakymulla

b-j-roberts added a commit that referenced this issue Jul 29, 2024
@ptisserand @b-j-roberts
[feat] OP_[2..16] and OP_MIN implementation (#33)
256c2da 
* feat: #5 add `OP_[2..16]` opcodes

* feat: #17 add `OP_MIN` opcode

---------

Co-authored-by: Brandon Roberts <brandonjroberts22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptisserand ptisserand

@hakymulla hakymulla

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ptisserand @hakymulla @b-j-roberts