Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Translation madara beast article.md #958

Merged
merged 16 commits into from
Aug 17, 2023

Conversation

joaopereira12
Copy link
Contributor

Please add the labels corresponding to the type of changes your PR introduces:

  • Documentation content changes

Resolves: #921

What is the new behavior?

madara beast article.md is translated to portuguese.

Does this introduce a breaking change?

No

@d-roak
Copy link
Collaborator

d-roak commented Aug 2, 2023

I'll review it

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (57b4931) 43.37% compared to head (faf3fe3) 43.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #958   +/-   ##
=======================================
  Coverage   43.37%   43.37%           
=======================================
  Files          88       88           
  Lines       10820    10820           
  Branches    10820    10820           
=======================================
  Hits         4693     4693           
  Misses       5594     5594           
  Partials      533      533           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/content/articles/pt/madara-beast-article.md Outdated Show resolved Hide resolved
docs/content/articles/pt/madara-beast-article.md Outdated Show resolved Hide resolved
docs/content/articles/pt/madara-beast-article.md Outdated Show resolved Hide resolved
docs/content/articles/pt/madara-beast-article.md Outdated Show resolved Hide resolved
docs/content/articles/pt/madara-beast-article.md Outdated Show resolved Hide resolved
docs/content/articles/pt/madara-beast-article.md Outdated Show resolved Hide resolved
docs/content/articles/pt/madara-beast-article.md Outdated Show resolved Hide resolved
docs/content/articles/pt/madara-beast-article.md Outdated Show resolved Hide resolved
docs/content/articles/pt/madara-beast-article.md Outdated Show resolved Hide resolved
docs/content/articles/pt/madara-beast-article.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double check consistency along the translation

@tdelabro
Copy link
Collaborator

@d-roak is this ready to be merged?

@tdelabro tdelabro requested a review from d-roak August 16, 2023 08:40
@d-roak
Copy link
Collaborator

d-roak commented Aug 16, 2023

@d-roak is this ready to be merged?

no, spell-check is not fixed yet, how should we ignore the articles? all in the path (including the en)?

@tdelabro
Copy link
Collaborator

@d-roak What is spell check doing exactly? Why is it an issue?

@d-roak
Copy link
Collaborator

d-roak commented Aug 16, 2023

@d-roak What is spell check doing exactly? Why is it an issue?

@tdelabro something we add it somewhere in time (before i arrived), that checks the english spelling in stuff... We can add files/paths to be ignored in the .codespellignore

edit:
e.g. of the ru being ignored: https://github.com/keep-starknet-strange/madara/pull/936/files

edit2:
that file ignores words, it doesn't ignore files/paths

@d-roak d-roak merged commit 62ec8d7 into keep-starknet-strange:main Aug 17, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: translate Madara article and website to Portuguese
3 participants