This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
dev : add pragma api to compute fees in STRK #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvolveArt
reviewed
Jun 19, 2024
EvolveArt
reviewed
Jun 20, 2024
EvolveArt
approved these changes
Jun 20, 2024
tdelabro
suggested changes
Jun 20, 2024
tdelabro
approved these changes
Jun 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
STRK gas price are computed with a constant eth/strk price
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
No
Other information
🚨Not mergeable yet 🚨
This should work, however i don't know how to handle api key. I was planning to put it in a config file but i struggle ton handle this within the code.