This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
fix: remove unecessary checks before tx execution #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdelabro
force-pushed
the
remove-duplicate-checks
branch
from
5a1a433
to
6dd1d4a
Compare
tdelabro
force-pushed
the
remove-duplicate-checks
branch
from
6dd1d4a
to
21f2c2b
Compare
EvolveArt
approved these changes
Jun 5, 2024
apoorvsadana
approved these changes
Jun 5, 2024
| @@ -576,17 +568,6 @@ pub mod pallet { | |||
| // This ensures that the function can only be called via unsigned transaction. | |||
| ensure_none(origin)?; | |||
|
|
|||
| // Check class hash is not already declared | |||
| ensure!( | |||
There was a problem hiding this comment.
so what happens if its already declared, does it fail or it just overrides?
tdelabro
commented
Jun 6, 2024
| @@ -146,7 +146,7 @@ fn given_contract_declare_tx_works_once_not_twice() { | |||
| assert_eq!(Starknet::contract_class_by_class_hash(class_hash.0).unwrap(), contract_class); | |||
| // TODO: Uncomment once we have ABI support | |||
| // assert_eq!(Starknet::contract_class_by_class_hash(erc20_class_hash), erc20_class); | |||
| assert_err!(Starknet::declare(none_origin, transaction), Error::<MockRuntime>::ClassHashAlreadyDeclared); | |||
There was a problem hiding this comment.
@apoorvsadana it fails
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing those checks we will return same errors are Starknet rather than our customs ones (when we will be able to return complex errors from runtime)