Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

ci: add coverage #1108

Closed
wants to merge 24 commits into from
Closed

Conversation

d-roak
Copy link
Collaborator

@d-roak d-roak commented Sep 18, 2023

Testing #1122 while re adding coverage

@d-roak d-roak marked this pull request as draft September 18, 2023 08:20
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Attention: 1045 lines in your changes are missing coverage. Please review.

Comparison is base (2e2d580) 40.71% compared to head (aeba30e) 41.35%.
Report is 23 commits behind head on main.

❗ Current head aeba30e differs from pull request most recent head c05ac24. Consider uploading reports for the commit c05ac24 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
+ Coverage   40.71%   41.35%   +0.64%     
==========================================
  Files          96      119      +23     
  Lines       11069    11707     +638     
  Branches    11069    11707     +638     
==========================================
+ Hits         4507     4842     +335     
- Misses       6050     6338     +288     
- Partials      512      527      +15     
Files Coverage Δ
crates/client/rpc-core/src/lib.rs 0.00% <ø> (ø)
crates/client/rpc-core/src/tests.rs 97.14% <ø> (+1.22%) ⬆️
crates/client/rpc-core/src/utils.rs 0.00% <ø> (-65.56%) ⬇️
crates/client/rpc/src/types.rs 88.88% <100.00%> (-0.59%) ⬇️
...ates/pallets/starknet/src/offchain_worker/types.rs 0.00% <ø> (ø)
...src/crypto/merkle_patricia_tree/ref_merkle_node.rs 56.12% <100.00%> (ø)
...ves/starknet/src/transaction/compute_hash_tests.rs 100.00% <100.00%> (ø)
crates/runtime/src/pallets.rs 0.00% <ø> (ø)
starknet-rpc-test/add_declare_transaction.rs 100.00% <100.00%> (ø)
...tarknet-rpc-test/add_deploy_account_transaction.rs 100.00% <100.00%> (ø)
... and 58 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdelabro
Copy link
Collaborator

Do we really want to add it now?
Don't it take insanely long to run?

@d-roak
Copy link
Collaborator Author

d-roak commented Sep 20, 2023

Do we really want to add it now? Don't it take insanely long to run?

This PR is a draft to test how we can do it. We need to re add the tests for sure, doesn't mean that it has to be now. We can still merge PR's (we need to be careful with the reviews though) @tdelabro

@d-roak
Copy link
Collaborator Author

d-roak commented Oct 6, 2023

closed in favor of #1145

@d-roak d-roak closed this Oct 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants