Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

ci: gomu gomu no gatling workflow integration #1101

Conversation

dbejarano820
Copy link
Contributor

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Other (please describe): CI Integration

What is the current behavior?

Resolves: #1097
No existing workflow to benchmark every PR with Gomu Gomu no Gatling

What is the new behavior?

Workflow with Gomu Gomu no Gatling action

Does this introduce a breaking change?

No

@dbejarano820
Copy link
Contributor Author

@d-roak Couple of Qs...

  • In order to setup the chain and benchmark every PR, what chain of commands should we be running before calling the action?

  • Where should the config file for the Gomu Gomu action live? What would be the rpc url?

@d-roak
Copy link
Collaborator

d-roak commented Sep 18, 2023

You can ask those directly on tg

  • right now madara --dev should be enough, in the near future:
    1. madara setup
    2. madara run --dev
  • the rpc should be localhost:9944, is the config a mandatory input? If yes, let's change the way we set this up on gomu gomu

CHANGELOG.md Show resolved Hide resolved
.github/workflows/benchmarks.yml Show resolved Hide resolved
@dbejarano820 dbejarano820 force-pushed the gomu-gomu-no-gatling-integration branch 6 times, most recently from 555c6ac to 123d8cc Compare September 23, 2023 14:44
@d-roak
Copy link
Collaborator

d-roak commented Sep 29, 2023

This PR is locked due to the long time it takes to run benchmarks. We need to first fix it

Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 19, 2023
@tdelabro tdelabro closed this Dec 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Integrate Gomu Gomu no Gatling benchmark in our CI
3 participants