Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:social account initialize with nostr public key #20

Merged
merged 24 commits into from
May 16, 2024
Merged

feat:social account initialize with nostr public key #20

merged 24 commits into from
May 16, 2024

Conversation

mubarak23
Copy link
Contributor

@mubarak23 mubarak23 commented May 10, 2024 •
edited
Loading

Social Account Contract #16
constructor that single storage slot - public_key

@vercel Vercel
Copy link

vercel bot commented May 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
joyboy ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 10:59am
joyboy-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 10:59am

@mubarak23 mubarak23 changed the title social account initialize with nostr public key feat:social account initialize with nostr public key May 10, 2024
maciejka
maciejka requested changes May 11, 2024
View reviewed changes
onchain/src/social_account.cairo Outdated Show resolved Hide resolved
onchain/src/social_account.cairo Outdated Show resolved Hide resolved
onchain/src/social_account.cairo Show resolved Hide resolved
onchain/src/social_account.cairo Outdated Show resolved Hide resolved
onchain/src/social_account.cairo Show resolved Hide resolved
@mubarak23
Copy link
Contributor Author

mubarak23 commented May 13, 2024 •
edited
Loading

what could cause this error

Run scarb test
     Running test joyboy (snforge test)
snforge: command not found

@maciejka

maciejka
maciejka requested changes May 13, 2024
View reviewed changes
onchain/src/social_account/social_account.cairo Outdated Show resolved Hide resolved
onchain/src/tests/social_account.cairo Outdated Show resolved Hide resolved
onchain/src/social_account/interfaces.cairo Outdated Show resolved Hide resolved
onchain/Scarb.toml Outdated Show resolved Hide resolved
@maciejka
Copy link
Collaborator

what could cause this error

Run scarb test
     Running test joyboy (snforge test)
snforge: command not found

@maciejka

snforge not installed correctly?

@maciejka
Copy link
Collaborator

what could cause this error

Run scarb test
     Running test joyboy (snforge test)
snforge: command not found

@maciejka

snforge not installed correctly?

You should add it to .github/workflows

@mubarak23
Copy link
Contributor Author

@maciejka kindly review, thank you

@mubarak23
Copy link
Contributor Author

kindly review @maciejka

maciejka
maciejka requested changes May 15, 2024
View reviewed changes
onchain/src/social_account.cairo Outdated Show resolved Hide resolved
onchain/src/social_account.cairo Outdated Show resolved Hide resolved
@mubarak23
Copy link
Contributor Author

@maciejka kindly review

maciejka
maciejka requested changes May 16, 2024
View reviewed changes
onchain/src/social_account.cairo Outdated Show resolved Hide resolved
@mubarak23 mubarak23 requested a review from maciejka May 16, 2024 10:41
@maciejka maciejka merged commit 0fdfd95 into keep-starknet-strange:main May 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejka maciejka maciejka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mubarak23 @maciejka