Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add typo detection tool #139

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Conversation

goofylfg
Copy link
Contributor

@goofylfg goofylfg commented May 31, 2024

Time spent on this PR: 1h

  • use typos-action detect typos in github action
  • fixed all checked typos && test github action
  • Exclude some false postive word, please refer to the configuration file for details. like.
error: `ba` should be `by`, `be`
  --> ./onchain/src/bip340.cairo:68:5
   |
68 |     ba.append_word(rx.low.into(), 16);
   |     ^^
   |
error: `ba` should be `by`, `be`
  --> ./onchain/src/bip340.cairo:70:5
   |
70 |     ba.append_word(px.high.into(), 16);

Result
image

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
joyboy ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 0:23am
joyboy-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 0:23am

@ugur-eren
Copy link
Collaborator

@maciejka do we need this?

@goofylfg
Copy link
Contributor Author

I think adding automated tools to check typos is a once and for all way to avoid many subsequent small PRs

@maciejka
Copy link
Collaborator

maciejka commented Jun 1, 2024

If it does not generate to many false positives.

Copy link
Collaborator

@ugur-eren ugur-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seems like creates false positives. LGTM

@ugur-eren ugur-eren merged commit 0c090f6 into keep-starknet-strange:main Jun 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants