Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth screens UI #114

Merged
merged 9 commits into from
Jun 2, 2024
Merged

Auth screens UI #114

merged 9 commits into from
Jun 2, 2024

Conversation

princeibs
Copy link
Contributor

Closes #92

@vercel Vercel
Copy link

vercel bot commented May 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
joyboy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 7:27am
joyboy-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 7:27am

@princeibs princeibs marked this pull request as draft May 27, 2024 14:00
@princeibs princeibs marked this pull request as ready for review May 30, 2024 16:22
ugur-eren
ugur-eren requested changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@ugur-eren ugur-eren left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've requested some changes regarding the SVGs. Also can you fix the linting issues? Other than that looks great! Thank you for the work.

@princeibs
Copy link
Contributor Author

All issues resolved ✅
@ugur-eren

ugur-eren
ugur-eren approved these changes Jun 2, 2024
View reviewed changes
Copy link
Collaborator

@ugur-eren ugur-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work! LGTM

@ugur-eren ugur-eren merged commit 0c4a3e9 into keep-starknet-strange:main Jun 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ugur-eren ugur-eren ugur-eren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figma design: Auth screen
2 participants
@princeibs @ugur-eren