Rust implementation of the MultiPairingCheck calldata builder #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I reached a good point with this PR. I might have missed some obvious improvements/simplifications though. Please, let me know. |
|
I also intend to remove file test_mpc.py from the merge. It has been useful but in the end it can be removed. |
feltroidprime
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Good Job.
We can indeed optimize and clean here and there but overall it's good and it's better to move forward.
On top of the suggestions on a file-to-file basis and fixing conflicts with main, please make sure the wasm binding handles panics caused by rust asserts gracefully for the following cases (similarly to the msm calldata builder with the Result usage)
- Points are not on curve // deserialization of bigints fails
- Parameters are stupids (n_fixed_g2 > len(pairs))
- Mpc final result is != Polynomial::One. In that case return something " pairing check is not == 1 " .
hydra/garaga/starknet/tests_and_calldata_generators/test_mpc.py
Outdated
Show resolved
Hide resolved
…small adjustments
|
All requests resolved @feltroidprime, please check it out. Thanks |
feltroidprime
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
Issue Number: #191
Does this introduce a breaking change?