Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sorted completed quests and created daily and main quest routes #1 #54

Merged
merged 20 commits into from
Apr 22, 2024

Conversation

fishonamos
Copy link
Contributor

@fishonamos fishonamos commented Apr 17, 2024

  • Follow the contribution guidelines
  • On the Quests.js file add sorting for completed quests
  • Create Backend Route to Query Quests from Postgres
  • Expand route for dailyQuests and mainQuests.
  • Request mainQuests and dailyQuests route on the frontend Quest component.

This will solve #13

@fishonamos fishonamos marked this pull request as draft April 17, 2024 07:20
@b-j-roberts
Copy link
Contributor

Hey, thanks for the draft. Looking good so far!

@fishonamos fishonamos marked this pull request as ready for review April 17, 2024 21:50
@fishonamos fishonamos changed the title feat: added sorting for completed quests#1 feat: added sorting for completed quests and created a route#1 Apr 17, 2024
@fishonamos fishonamos changed the title feat: added sorting for completed quests and created a route#1 feat: added sorting for completed quests and created a quest route#1 Apr 17, 2024
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you'll be able to make these changes. Thank you for the work so far!

backend/core/quest.go Outdated Show resolved Hide resolved
backend/routes/Quests.go Outdated Show resolved Hide resolved
backend/routes/routes.go Outdated Show resolved Hide resolved
backend/routes/routes.go Outdated Show resolved Hide resolved
@fishonamos
Copy link
Contributor Author

fishonamos commented Apr 19, 2024

Hi @b-j-roberts,

I made some changes and modifications to accommodate the new getDailyQuests and getMainQuests.

I also updated the Quest interface to accommodate these new change.
In art-peace/backend/routes/Quests.go, I removed the gorilla/mux package and created two separate handler functions getDailyQuests and getMainQuests for the two quests types. I also updated the InitQuestsRoutes function to register these new handler functions.

Finally. I consumed the routes on the frontend.

@fishonamos fishonamos changed the title feat: added sorting for completed quests and created a quest route#1 feat: add sorting for completed quests and create daily and main quest routes#1 Apr 20, 2024
@fishonamos fishonamos changed the title feat: add sorting for completed quests and create daily and main quest routes#1 feat: added sorting for completed quests and created daily and main quest routes #1 Apr 20, 2024
@fishonamos fishonamos changed the title feat: added sorting for completed quests and created daily and main quest routes #1 feat: sorted completed quests and created daily and main quest routes #1 Apr 20, 2024
@b-j-roberts b-j-roberts merged commit 3fa4ac8 into keep-starknet-strange:main Apr 22, 2024
3 checks passed
@b-j-roberts
Copy link
Contributor

Nice work by the way, and thanks for making that change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants