Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix mouse zoom issues #195

Closed
wants to merge 7 commits into from
Closed

fix: fix mouse zoom issues #195

wants to merge 7 commits into from

Conversation

EjembiEmmanuel
Copy link
Contributor

@EjembiEmmanuel EjembiEmmanuel commented May 28, 2024 •
edited
Loading

This PR enhances mouse zoom by making it smoother for mouse and trackpad users

@vercel Vercel
Copy link

vercel bot commented May 28, 2024

@EjembiEmmanuel is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

b-j-roberts
b-j-roberts requested changes May 31, 2024
View reviewed changes
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't solve the issue of large jumps when zooming with the mouse.

I think the best solution will be to sort of interpolate the zoom over time, so it doesn't jump too far at once.

@EjembiEmmanuel
Copy link
Contributor Author

Alright, I'll try it out

b-j-roberts
b-j-roberts requested changes May 31, 2024
View reviewed changes
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this setup you can no longer pan the canvas after zooming.

@EjembiEmmanuel
Copy link
Contributor Author

Oh, I forgot to test for that. I'll trace the bug and fix it.

@b-j-roberts
Copy link
Contributor

Ended up mostly resolving the issue as part of this PR, so I will close this.
Thanks for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-roberts b-j-roberts Awaiting requested review from b-j-roberts b-j-roberts is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EjembiEmmanuel @b-j-roberts