Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

v0.10.0

Pre-release
Pre-release
Compare
Choose a tag to compare
@sthompson22 sthompson22 released this 16 Mar 20:24
fbb2018
Merge pull request #515 from keep-network/two-step-gov

Two-step change for governable values

Changing/upgrading things in the System contract without warning can lead to
unpredictable function call behavior, meaning a user can submit a transaction
whose behavior changes compared to when they submitted it, without any warning.

This PR makes all upgrades require two steps with a mandatory time window
between them. The first step merely broadcasts to users that a particular
change is coming, and the second step commits that change after a suitable
waiting period.

Details:
- Governance Time delay 1 hour, set arbitrarily.
- Currently, the initial update functions are unlocked. This means that if a
  change is incoming and is halfway through the waiting period, the initial
  update function can be called again, the timer resets, an event is fired and
  the new change is now pending.