This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
fix: throw nested revert messages #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamzebedee
force-pushed
the
nested-revert-msg
branch
from
d0e7a33
to
66516f2
Compare
Shadowfiend
reviewed
Apr 22, 2020
| // Slicing the Error() signature (4 bytes) and Data offset (4 bytes) | ||
| // leaves us with a pre-encoded string. | ||
| // We also slice off the ABI-coded length of returnData (32). | ||
| revertMessage := add(returnData, 0x44) |
There was a problem hiding this comment.
Could help to articulate the return data length in something more similar to byte (e.g. either nibble, or half byte), or clarify that it's 32 bits. Got confused on the math for a moment heh.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509