This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Constitutionally Limited: Impose certain additional limits on governance actions #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadowfiend
changed the title
Shadowfiend
force-pushed
the
constitutionally-limited
branch
from
ed307d7
to
21f2ae2
Compare
This to avoid the ability to disable the system by simply zeroing out the signer fee through governance.
This to avoid signer DoS (for the minimum 0.0005 BTC lot size) and to avoid putting more funds at risk than reasonable in a single deposit (for the maximum 10 BTC lot size).
Shadowfiend
force-pushed
the
constitutionally-limited
branch
from
21f2ae2
to
2ad6872
Compare
|
@liamzebedee @NicholasDotSol this is ready for one of you to have a look at. |
liamzebedee
reviewed
Apr 20, 2020
| ); | ||
| require( | ||
| _signerFeeDivisor < 2000, | ||
| "Signer fee divisor must be less than 2000, for a signer fee that is > 5bps." |
There was a problem hiding this comment.
Perhaps > 0.005% instead of quoting bps? We use % fairly consistently.
There was a problem hiding this comment.
That’s fair, yeah.
Specifically, the revert message was in basis points while the one for the upper bound was in percent. Align on percentages, which are used in several other places as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three limitations on governance actions:
Still needed:
Closes #552 .