This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
4x400: Early pass at a relay maintainer initcontainer #575
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,3 +17,6 @@ node_modules/ | |
| .mypy_cache | ||
| # Visual Studio Code | ||
| *.code-workspace | ||
|
|
||
| # infrastructure | ||
| .secrets | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: bcoin | ||
| namespace: default | ||
| labels: | ||
| app: bitcoin-node | ||
| type: bcoin | ||
| spec: | ||
| ports: | ||
| - port: 18332 | ||
| targetPort: 18332 | ||
| name: testnet-rpc | ||
| - port: 18333 | ||
| targetPort: 18333 | ||
| name: testnet | ||
| selector: | ||
| app: bitcoin-node | ||
| type: bcoin |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| --- | ||
| apiVersion: apps/v1 | ||
| kind: StatefulSet | ||
| metadata: | ||
| name: bcoin | ||
| namespace: default | ||
| labels: | ||
| app: bitcoin-node | ||
| type: bcoin | ||
| spec: | ||
| replicas: 1 | ||
| serviceName: bcoin | ||
| volumeClaimTemplates: | ||
| - metadata: | ||
| name: bcoin-data | ||
| spec: | ||
| accessModes: [ReadWriteOnce] | ||
| resources: | ||
| requests: | ||
| storage: 40Gi | ||
| selector: | ||
| matchLabels: | ||
| app: bitcoin-node | ||
| type: bcoin | ||
| template: | ||
| metadata: | ||
| labels: | ||
| app: bitcoin-node | ||
| type: bcoin | ||
| spec: | ||
| containers: | ||
| - name: bcoin | ||
| image: gcr.io/keep-dev-fe24/bcoin | ||
| ports: | ||
| - containerPort: 18332 | ||
| - containerPort: 18333 | ||
| env: | ||
| - name: BCOIN_NETWORK | ||
| value: testnet | ||
| - name: BCOIN_HTTP_HOST | ||
| value: '0.0.0.0' | ||
| - name: BCOIN_HTTP_PORT | ||
| value: '18332' | ||
| - name: BCOIN_PORT | ||
| value: '18333' | ||
| - name: BCOIN_LOG_LEVEL | ||
| value: info | ||
| - name: BCOIN_PREFIX | ||
| value: /mnt/.bcoin | ||
| - name: BCOIN_API_KEY | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: bcoin | ||
| key: http-api-key | ||
| volumeMounts: | ||
| - name: bcoin-data | ||
| mountPath: /mnt/.bcoin | ||
| command: | ||
| ["bcoin"] | ||
| volumes: | ||
| - name: bcoin-data | ||
| persistentVolumeClaim: | ||
| claimName: bcoin-data |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| --- | ||
| apiVersion: extensions/v1beta1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: relay-maintainer | ||
| namespace: default | ||
| labels: | ||
| keel.sh/policy: all | ||
| app: maintainer | ||
| type: relay | ||
| spec: | ||
| replicas: 1 | ||
| selector: | ||
| matchLabels: | ||
| app: maintainer | ||
| type: relay | ||
| template: | ||
| metadata: | ||
| labels: | ||
| app: maintainer | ||
| type: relay | ||
| spec: | ||
|
|
||
| initContainers: | ||
| - name: initcontainer-provision-relay-maintainer | ||
| image: gcr.io/keep-dev-fe24/initcontainer-provision-relay-maintainer | ||
| imagePullPolicy: Always | ||
| env: | ||
|
|
||
| - name: ETH_RPC_URL | ||
| valueFrom: | ||
| configMapKeyRef: | ||
| name: eth-network-internal | ||
| key: rpc-url | ||
|
|
||
| - name: ETH_NETWORK_ID | ||
| valueFrom: | ||
| configMapKeyRef: | ||
| name: eth-network-internal | ||
| key: network-id | ||
|
|
||
| - name: ETH_NETWORK_NAME | ||
| value: internal | ||
|
|
||
| - name: RELAY_MAINTAINER_ETH_ACCOUNT_ADDRESS | ||
| valueFrom: | ||
| configMapKeyRef: | ||
| name: eth-account-info | ||
| key: account-0-address | ||
|
|
||
| - name: RELAY_MAINTAINER_ETH_ACCOUNT_PRIVATE_KEY | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: eth-account-privatekeys | ||
| key: account-0 | ||
|
|
||
| - name: CONTRACT_OWNER_ETH_ACCOUNT_ADDRESS | ||
| valueFrom: | ||
| configMapKeyRef: | ||
| name: eth-network-internal | ||
| key: contract-owner-eth-account-address | ||
|
|
||
| - name: CONTRACT_OWNER_ETH_ACCOUNT_PRIVATE_KEY | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: eth-network-internal | ||
| key: contract-owner-eth-account-private-key | ||
|
|
||
| - name: BCOIN_HOST | ||
| value: bcoin.default.svc.cluster.local | ||
|
|
||
| - name: BCOIN_PORT | ||
| value: '18332' | ||
|
|
||
| - name: BCOIN_API_KEY | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: bcoin | ||
| key: http-api-key | ||
|
|
||
| volumeMounts: | ||
| - name: relay-maintainer-env | ||
| mountPath: /mnt/relay-maintainer | ||
| command: ['node', '/tmp/provision-relay-maintainer.js'] | ||
|
There was a problem hiding this comment. The There was a problem hiding this comment. I go back and forth on this, it feels good to be explicit on the app config with what command is being run for a container, even if it's the default entry point. There was a problem hiding this comment. I feel like this is probably true for external containers, since they can change out from under you, but for containers we control it feels like we're just doubling our workload whenever we need to change something… Either way, it's fine for this PR, especially if it's what we've been doing elsewhere. |
||
|
|
||
| containers: | ||
| - name: relay-maintainer | ||
| image: gcr.io/keep-dev-fe24/relay-maintainer | ||
| imagePullPolicy: Always | ||
| volumeMounts: | ||
| - name: relay-maintainer-env | ||
| mountPath: /mnt/relay-maintainer | ||
|
|
||
| volumes: | ||
| - name: relay-maintainer-env | ||
| persistentVolumeClaim: | ||
| claimName: relay-maintainer-env | ||
|
|
||
| --- | ||
| apiVersion: v1 | ||
| kind: PersistentVolumeClaim | ||
| metadata: | ||
| name: relay-maintainer-env | ||
| namespace: default | ||
| spec: | ||
| accessModes: | ||
| - ReadWriteOnce | ||
| resources: | ||
| requests: | ||
| storage: 5Mi | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: bcoin | ||
| namespace: default | ||
| labels: | ||
| app: bitcoin-node | ||
| type: bcoin | ||
| spec: | ||
| ports: | ||
| - port: 18332 | ||
| targetPort: 18332 | ||
| name: testnet-rpc | ||
| - port: 18333 | ||
| targetPort: 18333 | ||
| name: testnet | ||
| selector: | ||
| app: bitcoin-node | ||
| type: bcoin |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put some space between a few values for readability while we work through this.