This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Migration Resiliency: Try to fix migration non-timeout timeouts #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README was still referencing the outdated GitHub Package Registry deployment.
Be specific about which version of Solidity our contracts expect.
There are situations where the utility box script does not seem to finish, leading to a build timeout in Circle; explicitly exiting will hopefully end that once and for all.
sthompson22
approved these changes
Apr 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also dropped a couple of doc updates in. The main fix here is an explicit
exit 0at the end of the utility script that runs contract migrations. The hope is that this
will let the build finish normally in some edge cases we're seeing where migrations
complete but the actual build job doesn't, leading to a Circle timeout and build
failure.