This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
CI-lons: Fix issue with package-lock and solc 0.5.17, try to ensure it doesn't happen again #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using npm install can, amongst other things, lead to misses when dependencies update and the lockfile is not updated alongside, as with the recent issue where the lockfile was incorrect for solc 0.5.17 and didn't fail the PR build, but did fail the merge build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
npm install, which failed to catch an issue with the PRthat moved us to solc 0.5.17 (#565) where the lockfile had an incorrect
SHA hash for the new version (likely due to an aggressive find/replace on
my part). This PR both fixes the lockfile hash and moves the build to use
npm ci, which will solely reference the lockfile and blow up if thingsaren't properly aligned.