This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Version Tether: Continuous packaging and versioning #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadowfiend
force-pushed
the
version-tether
branch
from
ce43841 to
301ece4
Compare
Auto-publishing is already happening on keep-core and keep-ecdsa, with a build-time-decided -pre build going out on every master merge. The package.json file for tbtc now references the latest version of that -pre build, and is ready to start including artifacts with the tbtc build as well. Finally, the version for tbtc is aligned to the keep-ecdsa and keep-core versions.
Drop an incorrect `main` setting, and fill in the repository, bugs, and homepage links. Also improve the package description.
Now that keep-ecdsa is publishing to the main npm repository, GitHub packages aren't being used.
This script is very close to the one used in keep-core and keep-ecdsa, and will eventually be abstracted out once the commonalities and differences shake out.
Shadowfiend
force-pushed
the
version-tether
branch
from
301ece4 to
fbc120e
Compare
Two parts here: - A symbolic link from node_modules that fixes the push that was failing due to contract resolution issues. - Add a `|| echo` with an error message if the push fails, so that the migration itself is not blocked by the push failure. Largely taken from a keep-core commit of the same ilk.
Shadowfiend
force-pushed
the
version-tether
branch
2 times, most recently
from
651ecfc to
6a6906e
Compare
sthompson22
approved these changes
Apr 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up the work in keep-core and keep-ecdsa to publish new,
artifacts-included npm packages on contract migration. It adds the same
functionality to tbtc, and additionally updates the version string referencing
keep-ecdsa to properly integrate with keep-ecdsa's versioning.
The major changes are as in keep-ecdsa:
package.jsonfor Solidity contracts is set to<version>-pre, with nonumeric suffix.
publish_npm_package, runs on master merge. Thisjob updates the package version to
-pre.<number>, where<number>represents a new, unpublished version.
artifacts/subdirectory and included in the package.
package repository).