Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

The Big Move: implementation -> solidity #538

Merged
merged 5 commits into from
Mar 24, 2020
Merged

The Big Move: implementation -> solidity #538

merged 5 commits into from
Mar 24, 2020

Conversation

Shadowfiend
Copy link
Contributor

@Shadowfiend Shadowfiend commented Mar 23, 2020

As promised. Update references in scripts and docs as well.


Missing:

  • Passing build.
  • Signoff from @sthompson22 on the infra bits.

This used to be in implementation/; for better alignment with other
Keep-managed repos, more future-proof layout, and better clarity to
boot, it now lives in solidity/.
keep-ecdsa is the name of the game now!
Copy link
Contributor

@sthompson22 sthompson22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like implementation/build/ and implementation/node_modules still exists, we want to keep those?

@Shadowfiend
Copy link
Contributor Author

Those may exist locally for you because they were untracked, but they shouldn't be in the repo. Branch view tracks: https://github.com/keep-network/tbtc/tree/the-big-move

@sthompson22
Copy link
Contributor

Those may exist locally for you because they were untracked, but they shouldn't be in the repo. Branch view tracks: https://github.com/keep-network/tbtc/tree/the-big-move

Gah! Thanks.

@sthompson22 sthompson22 merged commit 08e1426 into master Mar 24, 2020
@sthompson22 sthompson22 deleted the the-big-move branch March 24, 2020 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants