TS: Bitcoin/Electrum add getNetwork function #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function can be used to compare if the network supported by the server is the one the user wants. This can be used to find problems with configured URLs mismatch.
nkuba
requested review from
lukasz-zimnoch and
tomaszslabon
and removed request for
lukasz-zimnoch
nkuba
changed the title
lukasz-zimnoch
approved these changes
Jan 27, 2023
lukasz-zimnoch
previously approved these changes
Feb 2, 2023
The path was changed to a file.
tomaszslabon
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function can be used to compare if the network supported by the
server is the one the user wants. This can be used to find problems with misconfigured electrum API URL on the client start.
Depends on: #504
Refs: https://github.com/keep-network/optimistic-minting/issues/27