Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump packages versions in go.mod #781

Closed
wants to merge 4 commits into from
Closed

Conversation

jessica-ng
Copy link

@jessica-ng jessica-ng commented Nov 29, 2024

  • Ran go get -v -u ./... and updated the k8s api versions to the latest. Keel is incompatible with newer versions of k8s and this should allow it to be compatible with the latest k8s version

This should fix #772.

@david-garcia-garcia
Copy link
Collaborator

@jessica-ng the bump to go 1.23 requires updating the go version in the docker base images:

image

@jessica-ng
Copy link
Author

Thanks @david-garcia-garcia, I have addressed the go version in the dockerfiles + drone config.

I think there's just one test failing TestOCIDigest which I checked the digest in the registry online and it seems the same as the one defined in the test. But when I pull the image via docker pull it gives the digest mentioned in the error. So I think something on the registry side changed the digest of the image specified in the test. Perhaps we should update the digest in the test?

@david-garcia-garcia
Copy link
Collaborator

@jessica-ng yes it was an upstream change. Weird that a digest for such an old tag changed. In any case, I cloned your PR on the main repository and finished there tweaking the tests. It's already merged: #783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to handle sidecar container correctly
2 participants