Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Europython2020-sprint] Remove old CLI #455

Closed
wants to merge 1 commit into from
Closed

[Europython2020-sprint] Remove old CLI #455

wants to merge 1 commit into from

Conversation

louisguitton
Copy link
Contributor

@louisguitton louisguitton commented Jul 25, 2020

Description

While going through the documentation (at this stage) I was intrigued by the fact that the kedro CLI uses the iris starter as the default starter, and wanted to check if that was set as default in the click command.
So I opened kedro/cli/cli.py only to realise that it was the old version of the CLI and that the starter argument was not there at all.
I went to setup.py and confirmed L177 that the new CLI is used:

entry_points={"console_scripts": ["kedro = kedro.framework.cli:main"]}

Therefore, I'm removing the old CLI.

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
  • Added tests to cover my changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@mzjp2
Copy link
Contributor

mzjp2 commented Jul 25, 2020

Deleting the old CLI is a breaking change, so this would need to be merged into develop instead, since master contains backwards-compatible code to be released in 0.16.x and develop contains all breaking changes which will be merged in for 0.17.

I believe develop has already deleted the cli code so there isn’t anything to do :)

@louisguitton louisguitton deleted the rm-duplicate-cli branch July 25, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants