-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mermaid rendering on RTD is brittle #3395
Comments
Looks like the pupetteer version pinned by mermaid-cli is quite old mermaid-js/mermaid-cli#627 |
Upstream issue puppeteer/puppeteer#10556 Ways we can try to fix this:
We'd need a |
Or commit a pre-rendered PNG to the source tree and remind ourselves to re-render it when the source changes (which doesn't happen that often??) |
I like that option TBH have never been a big fan of using Mermaid to build dynamic graphics when a PNG will do. |
I want to make some changes to the docs that use the mermaid graphic anyway so will factor in a change to the graphics at the same time. |
sphinxcontrib-mermaid doesn't seem to support static pre-rendering mgaitan/sphinxcontrib-mermaid#134 |
I've been looking at tools for this like https://discourse.joplinapp.org/t/ability-to-save-export-mermaid-graphs-as-image/23491 |
Yeah we can actually take the output from |
We can put it in a comment though, right? |
That's where my mind was right now... Essentially we can call mermaid-cli ourselves once with these parameters, store the PNG under version control, and have the Mermaid code as a comment next to the diagram itself. Line 554 in 543fa8b
I'll send a PR with this. |
Fix gh-3395. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Fix gh-3395. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Recently I've been spotting some intermittent failures caused by the Mermaid rendering:
https://readthedocs.org/projects/kedro/builds/22757197/
The text was updated successfully, but these errors were encountered: