Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing highlight width inconsistencies in list panel #2004

Merged
merged 9 commits into from
Aug 15, 2024

Conversation

rashidakanchwala
Copy link
Contributor

@rashidakanchwala rashidakanchwala commented Jul 26, 2024

Description

Resolves #2002

Development notes

Known Issue: When hovering over the 'Expand Pipeline' icon, the entire width is not highlighted. This issue arises due to the complexity of the MUI Tree structure. Attempting to fix this causes other elements to break. A follow-up ticket will be created to address this bug.

Steph: Given its complexity, please let me know if this issue should be considered a low priority, as it does not affect the slicing issue.

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@rashidakanchwala rashidakanchwala marked this pull request as ready for review July 26, 2024 13:56
@stephkaiser
Copy link

Thanks Rashida! some comments from me:

  1. the full-width highlights looks great! it seems like parameters still have the shorter width, could we include parameters as well in this update?
  2. selecting a child node and then closing the pipeline group doesnt bring the blue selection line to the parent level, can we also include this change? This would be useful in slicing when the contents of a pipeline are selected but not expanded

let me know if you want to discuss!

Signed-off-by: Huong Nguyen <huongg1409@gmail>
@Huongg
Copy link
Contributor

Huongg commented Aug 8, 2024

Thanks Rashida! some comments from me:

  1. the full-width highlights looks great! it seems like parameters still have the shorter width, could we include parameters as well in this update?
  2. selecting a child node and then closing the pipeline group doesnt bring the blue selection line to the parent level, can we also include this change? This would be useful in slicing when the contents of a pipeline are selected but not expanded

let me know if you want to discuss!

hey @stephkaiser, please see my reply as below:

  1. what you found there is actually a bug, when the parameter tag is off, user shouldn't be able to hover over it. I've fixed it now. So now if you turn the parameter tag on, hovering over the parameter should have the full width
  2. For this one, let me try to adjust this in the slicing PR rather than here. Because if we do it here it will introduce a new behaviour, as in now if you select the node, close the pipeline, the node will be deselected anyway, so it will be hard to highlight the pipeline. However in the slicing we keep the list of the node so should be able to do this one in that PR

@stephkaiser
Copy link

hey @stephkaiser, please see my reply as below:

  1. what you found there is actually a bug, when the parameter tag is off, user shouldn't be able to hover over it. I've fixed it now. So now if you turn the parameter tag on, hovering over the parameter should have the full width
  2. For this one, let me try to adjust this in the slicing PR rather than here. Because if we do it here it will introduce a new behaviour, as in now if you select the node, close the pipeline, the node will be deselected anyway, so it will be hard to highlight the pipeline. However in the slicing we keep the list of the node so should be able to do this one in that PR

Thanks Huong!

  1. I just had a look and this looks good to me!
  2. I'll review this part in the slicing PR, thanks

@Huongg
Copy link
Contributor

Huongg commented Aug 12, 2024

if so you're happy to approve the PR @stephkaiser so we can merge it?

@stephkaiser
Copy link

if so you're happy to approve the PR @stephkaiser so we can merge it?

done! thank you :)

Signed-off-by: Huong Nguyen <huongg1409@gmail>
@stephkaiser stephkaiser mentioned this pull request Aug 13, 2024
16 tasks
Signed-off-by: Huong Nguyen <huongg1409@gmail>
@Huongg Huongg merged commit 2087702 into main Aug 15, 2024
5 checks passed
@Huongg Huongg deleted the fix-hightlight-on-nodelist branch August 15, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing highlight width inconsistencies in list panel
3 participants