-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/gitpod #1862
Fix/gitpod #1862
Conversation
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
… ensure pyenv is available in the environment. Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Can we add this guide somewhere, for product/design and other people who want to QA easily. @astrojuanlu - notion, contributing.md ? |
Signed-off-by: huongg <huongg1409@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a small comment. Love the QA notes😄
Yes, please make this either a wiki page or add it to |
Signed-off-by: huongg <huongg1409@gmail.com>
Co-authored-by: Ravi Kumar Pilla <ravi_kumar_pilla@mckinsey.com> Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>
Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, soo excited about this!!! thanks Huong
Co-authored-by: Nok Lam Chan <nok_lam_chan@mckinsey.com> Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>
Co-authored-by: rashidakanchwala <37628668+rashidakanchwala@users.noreply.github.com> Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>
Co-authored-by: Ravi Kumar Pilla <ravi_kumar_pilla@mckinsey.com> Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>
Signed-off-by: huongg <huongg1409@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Description
Fixes #1854
Development notes
Updated the gitpod workspace-full to the version which has both Node 18 and Python 3.11.5
QA notes
1. Click on the Open icon on the right
2. It will open the gitpod workspace automatically
3. Wait until both FE and BE are done with their build. You can check it by clicking on
frontend
andbackend
. This can take around 5 minutes to fully finish4. Final step is to ensure that you unblock the pop-up ads in the browser, then refresh the browser again. It should then build the kedro-viz in gitpod workspace
Checklist
RELEASE.md
fileTRIBUTING.md) guidelines
RELEASE.md
file