Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for all Bugbash 8.0.0 findings #1767

Merged
merged 18 commits into from
Mar 1, 2024
Merged

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Feb 27, 2024

Description

As per title

Development notes

  • Fixed Preview row length display
  • Important doc note added under experiment tracking doc.
    Starting from version 8.0.0 of Kedro-Viz, Experiment Tracking is exclusively supported for users with kedro-datasets version 2.1 or higher.
  • Added banner in Experiment Tracking to let users know of bumping kedro-datasets to >= 2.1.0
  • Fixed a bug on kedro viz deploy command when bucket is not available in case of Azure

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

ravi-kumar-pilla and others added 2 commits February 26, 2024 18:12
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@jitu5
Copy link
Contributor

jitu5 commented Feb 27, 2024

Important doc note added under experiment tracking doc.
Starting from version 8.0.0 of Kedro-Viz, Experiment Tracking is exclusively supported for users with kedro-datasets version 2.1 or higher.

ravi-kumar-pilla and others added 9 commits February 27, 2024 09:49
…x/bugbash-8.0.0

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: <>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
…o-viz into fix/bugbash-8.0.0

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
Copy link
Contributor Author

Hi @stephkaiser,

Since there is a breaking change with kedro-datasets 2.1.0 for Kedro-Viz, we are showing the below banner for experiment-tracking on all the panels (Overview, Metrics, Plots) from Kedro-Viz versions 8.0.0 and above if the user has kedro-datasets version < 2.1.0. Please let us know if the banner looks fine from design perspective. Thank you

cc: @jitu5 thanks for the banner !

image

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@rashidakanchwala
Copy link
Contributor

Hi @stephkaiser,

Since there is a breaking change with kedro-datasets 2.1.0 for Kedro-Viz, we are showing the below banner for experiment-tracking on all the panels (Overview, Metrics, Plots) from Kedro-Viz versions 8.0.0 and above if the user has kedro-datasets version < 2.1.0. Please let us know if the banner looks fine from design perspective. Thank you

cc: @jitu5 thanks for the banner !

image

Not sure, if it needs to be yellow, but I will let Steph comment. Can it say kedro-datasets = 2.1.0

@jitu5
Copy link
Contributor

jitu5 commented Feb 29, 2024

Not sure, if it needs to be yellow, but I will let Steph comment. Can it say kedro-datasets = 2.1.0

@rashidakanchwala Updated kedro-datasets version number to 2.1.0 in banner and important docs note.

Signed-off-by: <>

# Conflicts:
#	src/components/shareable-url-modal/shareable-url-modal.js
@stephkaiser
Copy link

hey team! thanks for flagging this to me. Some minor comments from me:

  • instead of the yellow can we follow the hover background colour used in the kedro version in the top right corner? but please keep the colour persistent for this text so it's always shown, not only when user hovers over the text. See below screenshots of what i mean for light and dark mode.
Screenshot 2024-02-29 at 15 41 52 Screenshot 2024-02-29 at 15 41 59
  • Can we also improve the text to make it slightly more helpful for users, maybe something like:

"Kedro-Viz Experiment Tracking is only supported with kedro-datasets version 2.1.0 and above. Please update kedro-datasets in order to use this feature."

  • the placement of the banner text looks good too, could you share a full screenshot so I can check spacing/padding?

let me know if you guys have any further thoughts or questions, thanks!

@jitu5
Copy link
Contributor

jitu5 commented Feb 29, 2024

hey team! thanks for flagging this to me. Some minor comments from me:

  • instead of the yellow can we follow the hover background colour used in the kedro version in the top right corner? but please keep the colour persistent for this text so it's always shown, not only when user hovers over the text. See below screenshots of what i mean for light and dark mode.

Screenshot 2024-02-29 at 15 41 52 Screenshot 2024-02-29 at 15 41 59

  • Can we also improve the text to make it slightly more helpful for users, maybe something like:

"Kedro-Viz Experiment Tracking is only supported with kedro-datasets version 2.1.0 and above. Please update kedro-datasets in order to use this feature."

  • the placement of the banner text looks good too, could you share a full screenshot so I can check spacing/padding?

let me know if you guys have any further thoughts or questions, thanks!

@stephkaiser
Screenshot 2024-02-29 at 4 10 17 p m
Screenshot 2024-02-29 at 4 10 01 p m

@jitu5
Copy link
Contributor

jitu5 commented Feb 29, 2024

@stephkaiser Please review and let me know if it needs any more changes.
Screenshot 2024-02-29 at 4 26 49 p m
Screenshot 2024-02-29 at 4 26 38 p m

@stephkaiser
Copy link

Thank you @jitu5 the padding/spacing of the banner text looks good to me!

I just noticed the font size is slightly bigger, can we make sure its the same font size as the text below and the Overview/Metrics/Plots tab labels?

Signed-off-by: <>
Signed-off-by: <>
@jitu5
Copy link
Contributor

jitu5 commented Feb 29, 2024

@stephkaiser Thanks.
Banner text font size matched with Overview/Metrics/Plots tab labels.

Copy link
Contributor

@NeroOkwa NeroOkwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ravi-kumar-pilla

Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ravi-kumar-pilla LGTM from a backend standpoint.

@ravi-kumar-pilla ravi-kumar-pilla merged commit 037d01d into main Mar 1, 2024
14 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the fix/bugbash-8.0.0 branch March 1, 2024 15:52
@ravi-kumar-pilla ravi-kumar-pilla mentioned this pull request Mar 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants