Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python3.8 Support #1747

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Remove Python3.8 Support #1747

merged 3 commits into from
Feb 13, 2024

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Feb 12, 2024 •
edited
Loading

Description

Resolves #1746 and unblocks #1700

Development notes

  • Remove instances of python 3.8 from kedro viz requirement files and circle ci config
  • Update readME and Contribution docs to reflect support from python 3.9

QA notes

  • All tests should pass with python env >=3.9

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@ravi-kumar-pilla
initial draft
db25406 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
update release note
f48254b 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
fix read the docs
2b544ff 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review February 13, 2024 00:37
SajidAlamQB
SajidAlamQB approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ravi-kumar-pilla! 👍

@SajidAlamQB SajidAlamQB merged commit 5bb1deb into main Feb 13, 2024
16 checks passed
@SajidAlamQB SajidAlamQB deleted the chore/drop-py38 branch February 13, 2024 14:18
@ravi-kumar-pilla ravi-kumar-pilla mentioned this pull request Mar 1, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noklam noklam noklam approved these changes

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@tynandebold tynandebold Awaiting requested review from tynandebold

@yetudada yetudada Awaiting requested review from yetudada

@rashidakanchwala rashidakanchwala Awaiting requested review from rashidakanchwala rashidakanchwala is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Python3.8 Support
3 participants
@ravi-kumar-pilla @noklam @SajidAlamQB