Fix for Plotly chart not rendering #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashidakanchwala
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Amazing!! This has been a mind-boggling issue. We even faced this last year when building out metric plots. So glad it is solved.
Thanks a lot @jitu5
ravi-kumar-pilla
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Looking great and works well !! Nice to have this in the release note. Thank you @jitu5
| @@ -3,6 +3,7 @@ import RunDataset from '.'; | |||
| import { runs, trackingData } from '../../experiment-wrapper/mock-data'; | |||
| import JSONObject from '../../json-object'; | |||
| import { shallow, mount } from 'enzyme'; | |||
| import 'core-js/stable/structured-clone'; | |||
There was a problem hiding this comment.
Is this required ?
There was a problem hiding this comment.
Yes, structuredClone is not defined for jest test environment using NodeJS version below 17.0.0, Here its being pulled from core-js
| @@ -77,7 +77,12 @@ const RunDataset = ({ | |||
| trackingData, | |||
| theme, | |||
| }) => { | |||
| if (!trackingData) { | |||
| const clonedTrackingData = useMemo( | |||
| () => structuredClone(trackingData), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves issue under experiment tracking where Plotly graph is not rendering.
Development notes
Considering the nested nature of the
trackingData, it could be a data immutability issue causing the problem. To address this, I created a deep copy of thetrackingDatausingstructuredCloneand passed it to the<PlotlyChart>component.Checklist
RELEASE.mdfile