Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display hosted URL in CLI while launching kedro viz #1644

Merged
merged 10 commits into from
Dec 4, 2023
Merged

Display hosted URL in CLI while launching kedro viz #1644

merged 10 commits into from
Dec 4, 2023

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Nov 17, 2023 •
edited
Loading

Description

Resolves #1638

Development notes

  • Added print statement to display the url on which kedro viz has started running
  • Fixed dependency conflict of s3fs with kedro-datasets

QA notes

  • Install package using pip install -e package
  • cd demo-project
  • Run kedro viz
  • Url information as below should be displayed

image

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@ravi-kumar-pilla
add url to cli run
04bb408 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
test 0.18.2 kedro e2e
2bdd266 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
test pip version
5010cef 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
upgrade pip
6c14b81 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
adjust dependencies
eea1090 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review November 17, 2023 20:24
@ravi-kumar-pilla
add release note
585a902 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla changed the title Display URL in CLI while launching kedro viz Display hosted URL in CLI while launching kedro viz Nov 17, 2023
@astrojuanlu
Copy link
Member

I tested this with make run and I don't see the URL, is that expected?

  ~/Projects/QuantumBlack Labs/kedro-viz  feature/display-cli-url !1 ····  29s 23:41:04
❯ make run                                                               (kedro-viz38-dev) 
PYTHONWARNINGS="ignore:Kedro is not yet fully compatible" PYTHONPATH="/Users/juan_cano/Projects/QuantumBlack Labs/kedro-viz/package" python3 package/kedro_viz/server.py demo-project
Starting Kedro Viz Backend Server...
[11/19/23 23:41:10] WARNING  'exists()' not implemented for 'ImageDataSet'.     core.py:299
                             Assuming output does not exist.                               
                    WARNING  'exists()' not implemented for 'ImageDataSet'.     core.py:299
                             Assuming output does not exist.                               
[11/19/23 23:41:15] INFO     Checking for update...                          __init__.py:18

rashidakanchwala
rashidakanchwala reviewed Nov 20, 2023
View reviewed changes
package/kedro_viz/launchers/cli.py Outdated
@@ -165,7 +165,10 @@ def viz(

_wait_for(func=_check_viz_up, host=host, port=port)

print("Kedro Viz Backend Server started successfully...")
print(
"Kedro Viz Backend Server started successfully. \n\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Kedro Viz Backend Server started successfully. \n\n"
"Kedro Viz started successfully. \n\n"

@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz into fe…
db9cf85 
…ature/display-cli-url

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
fix review comments
fb60390 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
Copy link
Contributor Author

I tested this with make run and I don't see the URL, is that expected?

  ~/Projects/QuantumBlack Labs/kedro-viz  feature/display-cli-url !1 ····  29s 23:41:04
❯ make run                                                               (kedro-viz38-dev) 
PYTHONWARNINGS="ignore:Kedro is not yet fully compatible" PYTHONPATH="/Users/juan_cano/Projects/QuantumBlack Labs/kedro-viz/package" python3 package/kedro_viz/server.py demo-project
Starting Kedro Viz Backend Server...
[11/19/23 23:41:10] WARNING  'exists()' not implemented for 'ImageDataSet'.     core.py:299
                             Assuming output does not exist.                               
                    WARNING  'exists()' not implemented for 'ImageDataSet'.     core.py:299
                             Assuming output does not exist.                               
[11/19/23 23:41:15] INFO     Checking for update...                          __init__.py:18

I thought of fixing only the kedro viz command log statements and make run uses a different route to start the server. But it makes sense to fix both in this ticket. I have added the log statements to make run and made make run, kedro viz to follow the similar start pattern. Thank you !

rashidakanchwala
rashidakanchwala approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

NeroOkwa
NeroOkwa approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@NeroOkwa NeroOkwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I tested this locally with kedro viz and it worked perfectly.

@ravi-kumar-pilla ravi-kumar-pilla merged commit 8fa95a1 into main Dec 4, 2023
20 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the feature/display-cli-url branch December 4, 2023 17:40
This was referenced Dec 18, 2023
Closed
Merged
rashidakanchwala added a commit that referenced this pull request Dec 19, 2023
@rashidakanchwala
Release v7.0.0 (#1685)
8a34335 
Release 7.0.0

Major features and improvements

Upgrade to React 18. (Migrate to React 18 #1652)
Change CLI command to run Kedro-viz tokedro viz run. (Change 'Kedro Viz' to 'Kedro Viz Run' #1671)
Add deploy command to the CLI using kedro viz deploy for sharing Kedro-viz on AWS. (AWS focussed CLI implementation for Shareable Viz  #1661)
Add support for kedro==0.19and kedro-datasets==2.0. (Fix bug on kedro viz --load-file #1677)
Drop support for python=3.7. (Remove support for Python 3.7 #1660)
Drop support for kedro==0.17.x. (Drop Kedro 17  #1669)
Bug fixes and other changes
Fix modular pipelines breaking when collapsed on the flowchart. (Fix modular pipelines breaking when collapsed.  #1651)
Display hosted URL in CLI while launching Kedro viz. (Display hosted URL in CLI while launching kedro viz #1644)
Fix Kedro-viz display on Jupyter notebooks. (Fix Kedro-viz embedded as an IFrame #1658)
Fix zoom issues on the flowchart. (Flowchart doesn't automatically reset the zoom when actions are performed. #1672)
Fix bug on kedro-viz run --load-file. (Fix bug on kedro viz --load-file #1677)
Fix bug on adding timestamps to shareable-viz. (_#1679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@NeroOkwa NeroOkwa NeroOkwa approved these changes

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu astrojuanlu is a code owner

@tynandebold tynandebold Awaiting requested review from tynandebold

@yetudada yetudada Awaiting requested review from yetudada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display URL in CLI after launching kedro viz
4 participants
@ravi-kumar-pilla @astrojuanlu @rashidakanchwala @NeroOkwa