Issue #1548: Fix improper display of 'run command' text #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mehdinv <mehdinv@hotmail.com>
Signed-off-by: mehdinv <mehdinv@hotmail.com>
tynandebold
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Nice one! This fixes the problem.
I've left a small question about style and will let @rashidakanchwala or @ravi-kumar-pilla answer it.
Comment on lines
+414
to
+415
| if task_node.namespace is not None | ||
| else f"kedro run --to-nodes={kedro_node._name}" |
There was a problem hiding this comment.
Is this the way we normally write if/else statements in the codebase?
merelcht
approved these changes
Oct 12, 2023
Comment on lines
+414
to
+415
| if task_node.namespace is not None | ||
| else f"kedro run --to-nodes={kedro_node._name}" |
|
Yes, good call. Please add a line to the release notes after creating a new section titled |
Signed-off-by: mehdinv <mehdinv@hotmail.com>
tynandebold
reviewed
Oct 12, 2023
Co-authored-by: Tynan DeBold <thdebold@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1548
Task nodes that have no namespace, but a name present, will display their run command as
...None.(Node_name).The correct display should just be the
...(Node_name)onlyDevelopment notes
Purposely made changes very light to avoid unintentional bugs around the code (still unfamiliar with code base, so don't want to make large changes I can't predict the effects of).
Primary change for this PR is just to the text display; tells it to ignore 'None' values.
QA notes
Image Example
Before
After
