Skip to content

Commit

Permalink
keep error code, add suggested fix
Browse files Browse the repository at this point in the history
  • Loading branch information
kedhammar committed Nov 30, 2023
1 parent 727239f commit c84bbd7
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions .github/workflows/lint-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ jobs:
pip install isort
- name: isort --> Check for best-practice sorting of imports
run: |
msg="Suggest running 'isort .' to fix this."
msg="Suggested fix: run 'isort .' on this repo."
isort --check . \
|| echo "::error ::$msg"
|| echo "::error ::$msg" && exit 1
ruff-format:
runs-on: ubuntu-latest
Expand All @@ -50,7 +50,10 @@ jobs:
python -m pip install --upgrade pip
pip install ruff
- name: ruff --> Check code formatting
run: ruff format --check .
run: |
msg="Suggested fix: run 'ruff format .' on this repo."
ruff format --check . \
|| echo "::error ::$msg" && exit 1
mypy-check:
runs-on: ubuntu-latest
Expand All @@ -66,4 +69,4 @@ jobs:
python -m pip install --upgrade pip
pip install mypy
- name: mypy --> Static type checking
run: mypy --ignore-missing-imports --follow-imports=skip --exclude build .
run: mypy --ignore-missing-imports --follow-imports=skip --exclude build .

0 comments on commit c84bbd7

Please sign in to comment.