Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding zap-time-encoding argument to the KEDA Operator Deployment #766

Merged
merged 2 commits into from
Apr 21, 2020

Conversation

tbickford
Copy link
Contributor

This argument allows for changing of the timestamp date format in the logging of the KEDA Operator. This corresponds to the PR I have for the KEDA Helm Chart - kedacore/charts#41. I have left the zap-time-encoding-format at the default of the Operator SDK - epoch.

…allow changing of the time format used in logging

Signed-off-by: Travis Bickford <tbickford@shutterstock.com>
@zroubalik
Copy link
Member

zroubalik commented Apr 21, 2020

@tbickford thanks a lot!
Minor nit, could you please add a note on setting the correct values to do Logging section in https://github.com/kedacore/keda#keda-operator-logging ?

Signed-off-by: Travis Bickford <tbickford@shutterstock.com>
@tbickford
Copy link
Contributor Author

@zroubalik Thank you - Updated some of the description in the Logging section of the README. Let me know if you would prefer something different.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @tbickford !

@zroubalik zroubalik merged commit de809b6 into kedacore:master Apr 21, 2020
@tomkerkhove tomkerkhove added this to the v1.4.1 milestone Apr 27, 2020
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants