Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Refactor scaleHandler cont. #747

Merged
merged 1 commit into from
Apr 16, 2020
Merged

[v2] Refactor scaleHandler cont. #747

merged 1 commit into from
Apr 16, 2020

Conversation

zroubalik
Copy link
Member

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Minor fixes and refactoring:

  • getPods() return value was changed to *corev1.PodTemplateSpec
  • fixed ObjectMeta and TypeMeta in asDuckWithTriggers()
  • fixed logging in scale_scaleobjects.go

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik
Copy link
Member Author

the PR validation is till running against master which has old operator-sdk version, that's why it is failing

@ahmelsayed ahmelsayed merged commit 2d81976 into kedacore:v2 Apr 16, 2020
zroubalik added a commit to zroubalik/keda that referenced this pull request Apr 27, 2020
zroubalik added a commit to zroubalik/keda that referenced this pull request May 20, 2020
zroubalik added a commit to zroubalik/keda that referenced this pull request Jun 17, 2020
zroubalik added a commit to zroubalik/keda that referenced this pull request Jul 7, 2020
zroubalik added a commit that referenced this pull request Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants