Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new forgejo scaler #6495

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

cobak78
Copy link

@cobak78 cobak78 commented Jan 22, 2025

This PR adds a new forgejo autoscaler with the same characteristics of the github autoscaler.
Here is the issue for this feature #6488

Another important discussions on this topic:

Checklist

@cobak78 cobak78 requested a review from a team as a code owner January 22, 2025 14:40
@cobak78 cobak78 force-pushed the forgejo-runner-scaler branch from 03fd3a1 to 39fd60d Compare January 22, 2025 14:43
@cobak78 cobak78 force-pushed the forgejo-runner-scaler branch 2 times, most recently from 5b9d520 to f13dbc7 Compare January 23, 2025 11:41
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! I've left some comment inline. Additionally to them:

  • Please, add an e2e test covering the scaler. You get more info about how to do it here
  • Could you open a PR to docs adding the scaler in next version?
  • All commits must be signed and that's why DCO check is failing, please rebase your branch signing all the commits (how to do that it's explained in the check page)

@cobak78 cobak78 force-pushed the forgejo-runner-scaler branch 5 times, most recently from 5a3c0bd to 6b7ca20 Compare January 29, 2025 09:27
jaime merino added 3 commits January 29, 2025 10:43
Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz>
Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz>
Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz>
@cobak78 cobak78 force-pushed the forgejo-runner-scaler branch from 6b7ca20 to a63882e Compare January 29, 2025 09:45
Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz>
DISABLE_SSH = false
SSH_PORT = 22
LFS_START_SERVER = true
LFS_JWT_SECRET = OhcmN7vFFt95tIyvhe64gX0pzaKTaWG26bzGPRrd-cg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semgrep identified a blocking 🔴 issue in your code:
Generic Secret detected

To resolve this comment:

🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.

💬 Ignore this finding

Reply with Semgrep commands to ignore this finding.

  • /fp <comment> for false positive
  • /ar <comment> for acceptable risk
  • /other <comment> for all other reasons

Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by detected-generic-secret.

You can view more details about this finding in the Semgrep AppSec Platform.


[security]
INSTALL_LOCK = true
INTERNAL_TOKEN = eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJuYmYiOjE3Mjc5NjMxNTN9.QVlWC1Z5gEaxH598HMlVVglL3TwU7Hyv4_19ly0kc1g
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semgrep identified a blocking 🔴 issue in your code:
JWT token detected

To resolve this comment:

🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.

💬 Ignore this finding

Reply with Semgrep commands to ignore this finding.

  • /fp <comment> for false positive
  • /ar <comment> for acceptable risk
  • /other <comment> for all other reasons

Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by detected-jwt-token.

You can view more details about this finding in the Semgrep AppSec Platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants