Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump deps & k8s deps to 0.29.4 #5733

Merged
merged 3 commits into from
Apr 24, 2024
Merged

bump deps & k8s deps to 0.29.4 #5733

merged 3 commits into from
Apr 24, 2024

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Apr 23, 2024 •
edited
Loading

@zroubalik zroubalik requested a review from a team as a code owner April 23, 2024 17:16
@zroubalik zroubalik mentioned this pull request Apr 23, 2024
Closed
35 tasks
@zroubalik zroubalik changed the title bump deps & k8s deps to 1.29.4 bump deps & k8s deps to 0.29.4 Apr 23, 2024
@zroubalik zroubalik marked this pull request as draft April 23, 2024 17:17
@zroubalik
Copy link
Member Author

zroubalik commented Apr 23, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Apr 24, 2024
Closed
2 tasks
@zroubalik
Copy link
Member Author

zroubalik commented Apr 24, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@zroubalik zroubalik mentioned this pull request Apr 24, 2024
Merged
@dgrisonnet
Copy link

dgrisonnet commented Apr 24, 2024 •
edited
Loading

To fix the e2e test failure you need to add the following RBAC perm:

- apiGroups: ["flowcontrol.apiserver.k8s.io"]
  resources: ['prioritylevelconfigurations', 'flowschemas']
  verbs: ['list', 'watch']

to the metrics-server.

To give more info about this role, it allows for setting priority and fairness to requests. It essentially rate limit certain requests in favor of others based on a user defined config. https://kubernetes.io/docs/concepts/cluster-administration/flow-control/

@zroubalik
Copy link
Member Author

zroubalik commented Apr 24, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

dgrisonnet
dgrisonnet reviewed Apr 24, 2024
View reviewed changes
config/rbac/role.yaml Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member Author

zroubalik commented Apr 24, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@zroubalik
Copy link
Member Author

zroubalik commented Apr 24, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@zroubalik
bump deps & k8s deps to 1.29.4
cac6422 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik
bump deps
89c7952 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik
add flowcontrol.apiserver.k8s.io to RBAC
be926fe 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik
Copy link
Member Author

zroubalik commented Apr 24, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik marked this pull request as ready for review April 24, 2024 18:46
@zroubalik zroubalik merged commit 502c2ab into kedacore:main Apr 24, 2024
15 of 19 checks passed
@zroubalik zroubalik mentioned this pull request Apr 24, 2024
Merged
@joelsmith joelsmith mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet left review comments

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zroubalik @dgrisonnet @JorTurFer