Fix fallback logic in formula-based evaluation #5684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
JorTurFer
reviewed
Apr 11, 2024
|
/run-e2e internal |
|
@SpiritZhou can you fix conflict please? |
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
|
/run-e2e internal |
JorTurFer
approved these changes
Apr 23, 2024
|
/run-e2e internal |
JorTurFer
reviewed
Apr 24, 2024
JorTurFer
approved these changes
Apr 24, 2024
zroubalik
approved these changes
Apr 24, 2024
|
/run-e2e internal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed fallback logic in formula-based evaluation and return the correct metric value
Checklist
Fixes #5666