Improve README #565
Merged
Improve README #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
commented
Jan 25, 2020
README.md
Outdated
| 4. If you haven't downloaded them before, clone the charts repository: `git clone git@github.com:kedacore/charts.git` | ||
| 5. Still in terminal, navigate to the `chart/keda` folder (downlodaed in step 4), and run the following command (don't forget to replace the placeholder text in the command) `helm install . --set image.keda=kedacore/keda:$IMAGE_TAG,image.metricsAdapter=kedacore/keda-metrics-adapter:$IMAGE_TAG,image.pullPolicy=IfNotPresent`. This will use the images built at step 3. Notice the need to override the image pullPolicy to `IfNotPresent` in order to use the locally built images and not try to pull the images from remote repo on Docker Hub (and complain about not finding them). | ||
| 6. Once the keda operator pod is up, check the logs of both containers to verify everything running ok, eg: `kubectl logs <keda operator pod name> -c keda-operator-metrics-apiserver` and `kubectl logs <keda operator pod name> -c keda-operator` | ||
| 5. Still in terminal, navigate to the `charts/keda` folder (downlodaed in step 4), and run the following command |
There was a problem hiding this comment.
Here was a typo chart/keda -> charts/kead
There was a problem hiding this comment.
Thanks for fixing.. just noticed also this typo: (downlodaed
There was a problem hiding this comment.
Good catch! Fixed :)
|
It looks like the listing is now broken, can you please address that? |
Fixed :) |
ahmelsayed
approved these changes
Jan 27, 2020
|
Thank you @nuclearpinguin! |
preflightsiren
pushed a commit
to preflightsiren/keda
that referenced
this pull request
Nov 7, 2021
Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break lines in README.md and fix double spaces and a typo.