Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release workflow #559

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Fix release workflow #559

merged 1 commit into from
Jan 27, 2020

Conversation

ahmelsayed
Copy link
Contributor

No description provided.

@anirudhgarg
Copy link
Contributor

Looks good to me. Anyway to test this without actually triggering a new release.

@ahmelsayed
Copy link
Contributor Author

I only run it to validate the commands look right but not actually push.

@ahmelsayed ahmelsayed merged commit 8773eb1 into master Jan 27, 2020
@ahmelsayed ahmelsayed deleted the ahmels/release-workflow-fix branch January 27, 2020 20:43
preflightsiren pushed a commit to preflightsiren/keda that referenced this pull request Nov 7, 2021
* Fixed some values that should be Strings in stead of Integer

Signed-off-by: jeroenvandevelde <jeroen.vandevelde@live.be>

* Fixed the naming of some variables in the example as you should omit the default part

Signed-off-by: jeroenvandevelde <jeroen.vandevelde@live.be>

* Fixed the naming of some variables in the example as you should omit the default part

Signed-off-by: jeroenvandevelde <jeroen.vandevelde@live.be>

* Fixed the naming of some variables in the example as you should omit the default part

Signed-off-by: jeroenvandevelde <jeroen.vandevelde@live.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants