Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor refactor to reduce copy/paste code in ScaledObject webhook #5403

Merged

Conversation

wozniakjan
Copy link
Member

all in the title :)
intending to merge after 2.13.0 release so keeping as draft for now

Checklist

Fixes #5397

CHANGELOG.md Outdated Show resolved Hide resolved
@wozniakjan wozniakjan force-pushed the issue5397/small_refactor_for_so_webhook branch from 004f5d7 to 1d6172a Compare January 18, 2024 18:22
closes: kedacore#5397

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan wozniakjan force-pushed the issue5397/small_refactor_for_so_webhook branch from 1d6172a to 4f8797c Compare January 21, 2024 07:33
@wozniakjan wozniakjan marked this pull request as ready for review January 21, 2024 07:37
@wozniakjan wozniakjan requested a review from a team as a code owner January 21, 2024 07:37
@JorTurFer
Copy link
Member

JorTurFer commented Jan 21, 2024

/run-e2e internal
Update: You can check the progress here

@wozniakjan
Copy link
Member Author

/run-e2e internal

@JorTurFer
Copy link
Member

JorTurFer commented Jan 24, 2024

/run-e2e internal
Update: You can check the progress here

@zroubalik zroubalik merged commit cd57dd9 into kedacore:main Jan 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor ScaledObject webhook
3 participants